[Ffmpeg-devel] Re: [PATCH] Revised patch for HD DVD .EVO demuxing

[Michael Niedermayer]

Hi

On Thu, Jan 18, 2007 at 10:12:35AM +0000, Ian Caulfield wrote:
> On 1/18/07, Ian Caulfield <ian.caulfield at gmail.com> wrote:
> >
> >Hi,
> >
> >I've updated the patch to mpeg.c to address Michael's comments and to diff
> >against the latest svn. Attached.
> 
> 
> Oops, revised version that actually compiles attached.
> 
> Ian

[...]
> @@ -1541,7 +1603,7 @@
>      if (startcode == PRIVATE_STREAM_1 && !m->psm_es_type[startcode & 0xff]) {
>          startcode = get_byte(&s->pb);
>          len--;
> -        if (startcode >= 0x80 && startcode <= 0xbf) {
> +        if (startcode >= 0x80 && startcode <= 0xcf) {
>              /* audio: skip header */
>              get_byte(&s->pb);
>              get_byte(&s->pb);
> @@ -1629,15 +1691,22 @@
>      } else if (startcode >= 0x80 && startcode <= 0x87) {
>          type = CODEC_TYPE_AUDIO;
>          codec_id = CODEC_ID_AC3;
> -    } else if (startcode >= 0x88 && startcode <= 0x9f) {
> +    } else if ((startcode >= 0x88 && startcode <= 0x8f)
> +               ||( startcode >= 0x98 && startcode <= 0x9f)) {

please add a comment about what 90..97 is and what document + chaper/page 
says so also please add a comment that 98..9f maybe a typo ideally with a 
reference to some document which would list DTS with a smaller range


>          type = CODEC_TYPE_AUDIO;
>          codec_id = CODEC_ID_DTS;
> -    } else if (startcode >= 0xa0 && startcode <= 0xbf) {
> +    } else if (startcode >= 0xa0 && startcode <= 0xaf) {
>          type = CODEC_TYPE_AUDIO;
>          codec_id = CODEC_ID_PCM_S16BE;

why? this doesnt seem to intersect with any of the new ranges ...

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Why not whip the teacher when the pupil misbehaves? -- Diogenes of Sinope
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20070120/b8e11390/attachment.pgp>