[Ffmpeg-devel] [RFC] flash screen video encoder

[Benjamin Larsson]

Michael Niedermayer wrote:

>Hi
>
>On Tue, Jan 02, 2007 at 12:19:09AM +0100, Benjamin Larsson wrote:
>  
>
>>Hi, I'm working on a flashsv encoder. I can currently create a valid
>>bitstream with it, but only if the input pixfmt is BGR24. as soon as it
>>is something else the video in the encoded stream is garbage. So what
>>I'm I doing wrong when I'm handling the input data? I need BGR24 input
>>and I need to store the previous frame for easy access.
>>    
>>
>
>[...]
>  
>
>>+            //copy the block to the temp buffer before compression
>>+            copy_region_enc(p->data[0], s->tmpblock, s->image_height-(hp+hs+1), wp, hs, ws, s->frame.linesize[0]);
>>    
>>
>
>s->frame.linesize[0] vs. p->linesize[0]
>  
>

Yepp that fixed it, thanks.

>
>also keep in mind that the user app does not need to preserve the picture
>which it passes to the encoder for future frames, you must copy it unless
>CODEC_FLAG_INPUT_PRESERVED is set (probably not worth to support this as
>the copy will likely be only a small part of the encoding and few apps
>support CODEC_FLAG_INPUT_PRESERVED)
>
>[...]
>  
>

I'll copy it myself then.

MvH
Benjamin Larsson

-- 
new tiny signature