[Ffmpeg-devel] [PATCH 8/9] Doxygenize av_fast_realloc comments

[Panagiotis Issaris]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Hi,

Panagiotis Issaris schreef:
> Panagiotis Issaris schreef:
>> Michael Niedermayer schreef:
>>> On Fri, Feb 23, 2007 at 01:55:57PM +0100, Panagiotis Issaris wrote:
>>>> Michael Niedermayer schreef:
>>>>> On Thu, Feb 22, 2007 at 10:32:31PM +0100, Panagiotis Issaris wrote:
>>>>>> Panagiotis Issaris schreef:
>>>>>>> Michael Niedermayer schreef:
>>>>>>>> On Thu, Feb 22, 2007 at 08:47:58PM +0100, Panagiotis Issaris wrote:
>>>>>> [...]
>>>>>>>>>> additionally, this function is a internal function of avcodec
>>>>>>>>>> and should not be used outside, it shouldnt have a av_ prefix  but ff_
>>>>>>>>>> and it should be droped if normal av_realloc() is as fast (benchmark a
>>>>>>>>>> large number of reallocs)
>>> [...]
>> I'll update the benchmarking patch with my new acquired knowledge and
>> hopefully help determining the performance benefits of av_fast_realloc.
> 
> Here's an updated patch:
>  ffmpeg.c |  101
> +++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
>  1 file changed, 101 insertions(+)
> 
> 
> 71680 dezicycles in av_fast_realloc same size, 1 runs, 0 skips
> 37280 dezicycles in av_fast_realloc same size, 2 runs, 0 skips
>[...]
> 3184 dezicycles in av_realloc (big) increasing size, 8192 runs, 0 skips
> 3181 dezicycles in av_realloc (big) increasing size, 16384 runs, 0 skips
> 3376 dezicycles in av_realloc (big) increasing size, 32768 runs, 0 skips
> 3421 dezicycles in av_realloc (big) increasing size, 65531 runs, 5 skips

grep "6553. runs" \[Ffmpeg-devel\]\ \[PATCH\ 8_9\]\ Doxygenize\
av_fast_realloc\ comments.eml
1051 dezicycles in av_fast_realloc same size, 65536 runs, 0 skips
2057 dezicycles in av_realloc same size, 65533 runs, 3 skips
1333 dezicycles in av_fast_realloc increasing size, 65535 runs, 1 skips
3371 dezicycles in av_realloc increasing size, 65535 runs, 1 skips
1331 dezicycles in av_fast_realloc (big) increasing size, 65536 runs, 0
3421 dezicycles in av_realloc (big) increasing size, 65531 runs, 5 skips

Looking at the summary I'd say that the av_fast_realloc is still useful.
 Any other comments on that? If it should stay, I'll post the renaming
and doxygenizing patch again.

With friendly regards,
Takis
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.6 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iD8DBQFF5XkS9kOxLuzz4CkRAmoVAJ946Nkqg8hKVF8zbjVP6Ek1Nty6uQCfU9EH
nJKAz1SAZpp92LUJQ4nYZpA=
=nDkF
-----END PGP SIGNATURE-----