[Ffmpeg-devel] [PATCH]Update Doxygen comments for libavutil/tree.h

Dujardin Bernard dujardin.iut
Tue Feb 27 11:54:51 CET 2007


Diego Biurrun a ?crit :
> On Mon, Feb 26, 2007 at 11:49:50AM +0100, Dujardin Bernard wrote:
>   
>> Diego Biurrun a ?crit :
>>     
>>>> ? patch abstract of referenced post
>>>> + * if a insertion happened, then either key or NULL is returned (that
>>>> + * depends of the tree state and the implementation, you should make no
>>>> + * assumptions that its one or the other in the code)
>>>>         
>>> its --> it is or it's
>>>
>>> "its" is a possessive pronoun, just like "my" or "your" "his/her".  As a
>>> rule of thumb if you can replace "its" in a sentence by "his/her" and it
>>> still makes sense (apart from the changed gender), then you must use
>>> "its", if it does not, then you must use "it's/it is".
>>>
>>> For example:
>>>
>>> OK:
>>> The dog wagged its tail.  -->  The dog wagged his/her tail.
>>>
>>> Nonsense:
>>> It is a shame.  -->  His/her a shame.
>>>
>>> Does that clear things up?
>>>  
>>>       
>> Sorry, I have no pay attention to this "its"
>> Patch attached (tree.c also)
>>     
>
> Oh, it seems I have committed to tree.h, the file you had a patch for...
>
> Given how tired I am I'm not surprised I overlooked your patch.
>
> I'll sort it out tomorrow.
>
> Diego
>   
It seems that this patch had opened a hard grammatical debate.
I'm not a native english and I'm waiting the end of discussion to
eventually commit another patch.
Regards
Bernard




More information about the ffmpeg-devel mailing list