[Ffmpeg-devel] Mpeg2-ts encoder uses fixed PES payload size

[Kling, Fredrik]

Hi,

I have noticed that the MPEG2 TS Encoder (mpegtsenc.c in libavformat)
uses a fixed size buffer for the PES data. 
Is there a reason for this ?

Ex: ffmpeg -i videofile.264 -vcodec copy -f mpegts file.mpegts

Will produce quite a data-overhead due to ineffective PES handling.
Changing the PES handling to using the size (supplied by the AVPacket
structure, in function mpegts_write_packet) and reallocating properly
would allow for dynamic payload sizes instead of fixed.

Some other 'issues' found:
- The current mpegtsenc.c can not handle VC-1
- the SDT packet frequence seems quite flawed (adding an SDT packet
every second packet!), causing the TS to grow up to 64% bigger than the
actual ES it encapsulates...

Having no experience in supplying patches I am just wondering if someone
is intrested in the fixes, or if I should just keep it to myself...

Best Regards
Fredrik Kling

<DIV><FONT size="1">

E-mail confidentiality.
--------------------------------
This e-mail contains confidential and / or privileged information belonging to Spirent Communications plc, its affiliates and / or subsidiaries. If you are not the intended recipient, you are hereby notified that any disclosure, copying, distribution and / or the taking of any action based upon reliance on the contents of this transmission is strictly forbidden. If you have received this message in error please notify the sender by return e-mail and delete it from your system. If you require assistance, please contact our IT department at helpdesk at spirent.com.

Spirent Communications plc,
Spirent House, Crawley Business Quarter, Fleming Way, Crawley, West Sussex, RH10 9QL, United Kingdom.
Tel No. +44 (0) 1293 767676
Fax No. +44 (0) 1293 767677

Registered in England Number 470893
Registered at Spirent House, Crawley Business Quarter, Fleming Way, Crawley, West Sussex, RH10 9QL, United Kingdom 

Or if within the US,

Spirent Communications,
26750 Agoura Road, Calabasas, CA, 91302, USA.
Tel No. 1-818-676- 2300 

</FONT></DIV>