[Ffmpeg-devel] [PATCH] access all bitrates for amr nb encoding

[Benoit Fouet]

Michael Niedermayer wrote:
> Hi
>
> On Mon, Feb 26, 2007 at 09:23:08AM +0100, Benoit Fouet wrote:
>   
>> Hi,
>>
>> Benoit Fouet wrote:
>>     
>>> Hi,
>>>
>>> Michael Niedermayer wrote:
>>>   
>>>       
>>>> Hi
>>>>   
>>>> well the user could then set -ab Y -vb X
>>>> if he says -b it means all bitrates so its logic to well set all
>>>> sure it changes behavior and iam not sure its the best solution but 
>>>> IMHO its more consistant to prefix video by v when audio is prefixed by a
>>>>
>>>>   
>>>>     
>>>>         
>>> in that case, i agree...
>>> we will need to have new options though.
>>> if it is ok, then a first patch could be sent, which just splits
>>> avctx_opts to a table of contexts, and ensure the functionning is the
>>> same as before...
>>> then we could look at adding prefixed options (and remove audio specific
>>> stuff such as ar, ab, ...)
>>>
>>>   
>>>       
>> is something like the attached could suit ?
>>     
>
> yes
>
>   
ok, i'll send a mail with this patch...

> [...]
>   
>> and when we change options, we'll also need to change regression tests
>> script too, i guess...
>>     
>
> yes
>
> [...]
>   
ok... i'll try to do it when the patch is applied, so...

Ben