[Ffmpeg-devel] Re: [PATCH] pthreads-w32 check

[Ramiro Polla]

Re-replying, after a day of thoughts.

M?ns Rullg?rd wrote:

>ramiro at lisha.ufsc.br writes:
>
>  
>
>>Hello,
>>
>>Attached patch correctly checks for pthreads-w32 in its many formats.
>>(void) $func on check_func2 didn't do the trick. Args must be passed.
>>    
>>
>
>Why?
>  
>
It might be better to leave require2 as it is, and make a special check 
for pthreads-w32. (the "()"s are ugly)

>  
>
>>Changed last check_lib -lpthread to check_lib2 (should work on linux the
>>same way).
>>It then checks for -lpthreadGC2 (the one to be used with gcc), and if all
>>fails, it checks for the static library of pthreadGC2 (which must have
>>that define and those libraries).
>>    
>>
>
>What is pthreadGC2?  Never heard of that.
>
>  
>
Thinking about it, pthreads-w32 shouldn't be mixed with the pthreads 
check. It's ugly. pthreads-w32 is not 100% pthreads-compliant either 
(must be explicitely initialized on static libraries). I think it's 
better to add --enable-pthreads-w32 instead.

>>If x264 is built with pthreads-w32, it must also have those extra
>>libraries, so the order does matter. add_extralibs is not enough.
>>    
>>
>
>This should be solved some other way.
>  
>
Is it ok to use pkg-config for x264? (it defines the correct cflags and 
ldflags for pthreads-w32 too). And if pkg-config isn't available, then 
fallback to the current method.

Ramiro Polla