[Ffmpeg-devel] [PATCH] Remove PRI macros definition

[Måns Rullgård]

"Fran?ois Revol" <revol at free.fr> writes:

>> "Fran?ois Revol" <revol at free.fr> writes:
>> 
>> >> > > Attached patch removes defining PRI macros to some random 
>> > > > > value 
>> >> > > (based on
>> >> > > gcc) that may or may not work...
>> >> > >
>> >> > 
>> >> > OK with me.
>> >> 
>> >> with me too
>> >
>> > Definitely not.
>> > BeOS needs them.
>> > I'd rather have warnings because they are a bit wrong than not 
>> > build at 
>> > all.
>> > You shouldn't have to care if you have them already.
>> 
>> You won't get warnings, but you will get random stuff printed and
>> possibly crashes.  These defines need to go for the same reason we
>> removed the intXX_t typedefs.
>
> Then don't use them !
>
> This breaks the BeOS build.
> Either put them back, move them to os_support.h with ifdef I don't care 
> but fix this.

I don't care how much you shout.  This can only be fixed reliably in
the system headers.

To me, breaking the Beos build is a very small price to pay for
correct results on other systems.  There are exactly 2 (two) known
users of FFmpeg on Beos.  I'm sorry, but if you choose to use an
obscure system, you'll have to deal with the consequences yourself.

The Windows users finally accepted that we can't be expected to fix
deficiencies in their system headers, especially when doing so
reliably is impossible.  Now it's your turn.

-- 
M?ns Rullg?rd
mans at mansr.com