[Ffmpeg-devel] [PATCH] Added another GUID to asf.[ch]
Ryan Martell
rdm4
Tue Feb 20 21:17:49 CET 2007
On Feb 19, 2007, at 5:24 PM, Michael Niedermayer wrote:
> Hi
>
> On Mon, Feb 19, 2007 at 02:23:13PM -0600, Ryan Martell wrote:
>> Hi--
>>
>> Attached patch adds the stream_bitrate GUID to the asf parsing code,
>> and set stream bitrate properties accordingly.
>>
>> Values are set but currently unused; but will be necessary for mms
>> parsing.
>>
>
> [...]
>> @@ -345,6 +348,23 @@
>> + uint16_t streams = get_le16(pb);
>
> this doesnt need to be exactly 16 bits
>
>> + for(j = 0; j < streams; j++) {
>> + uint16_t flags;
>> + uint32_t bitrate;
>> + int stream_id;
>
> int stream_id, flags, bitrate;
> none of them needs to be exactly 32 or 16bits
>
>
> [...]
>> ASFStream streams[128]; ///< it's max number and
>> it's not that big
>> + uint32_t stream_bitrates[128]; ///< max number of streams,
>> bitrate for each (for streaming)
>> /* non streamed additonnal info */
>> uint64_t nb_packets; ///< how many packets
>> are there in the file, invalid if broadcasting
>
> please align the comment with the other comments
>
> [...]
All done as requested. See attached.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: asf_bitrate.patch
Type: application/octet-stream
Size: 2526 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20070220/f995facf/attachment.obj>
-------------- next part --------------
More information about the ffmpeg-devel
mailing list