[Ffmpeg-devel] [PATCH] av_log Doxygen docs

[Michael Niedermayer]

Hi

On Tue, Feb 20, 2007 at 11:40:29AM +0100, Panagiotis Issaris wrote:
> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA1
> 
> Hi,
> 
> Panagiotis Issaris schreef:
> > Michel Bardiaux schreef:
> >> Panagiotis Issaris wrote:
> >> [snip]
> >>>>> Here's an updated patch using the imho clearest description (the
> >>>>> second).
> >>>> [...]
> >>>>> + * Send the specified message to the log if the level is higher
> >>>>> than or equal to
> >>>>> + * the current av_log_level. By default, all logging messages are
> >>>>> sent to
> >>>> [...]
> >>>>> + * @param level The importance level of the message, lower values
> >>>>> signifying
> >>>>> + * higher importance.
> >>>> [...]
> >>>>
> >>>> lower is more important but level >= av_log_level is sent ? this cant be
> >>>> correct
> >>> No, I think level <= av_log_level is sent.
> >>>
> >>> libavutil/log.c:
> >>>     35     if(level>av_log_level)
> >>>     36         return;
> >> Aargh, sorry, I gave wrong indications. It is indeed "if the level is
> >> less than or equal to...".
> > 
> > 
> > I'm all confused now :)
> > 
> > To me it seems that ... oh I see now. The remark was about the general
> > function's explanation not the @param level option...
> > 
> >      31 void av_log_default_callback(void* ptr, int level, ...
> >      32 {
> >      33     static int print_prefix=1;
> >      34     AVClass* avc= ptr ? *(AVClass**)ptr : NULL;
> >      35     if(level>av_log_level)
> >      36         return;
> > 
> > I'll send a patch in a second.
> Here it is.

looks ok

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

While the State exists there can be no freedom; when there is freedom there
will be no State. -- Vladimir Lenin
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20070220/54ae1542/attachment.pgp>