[Ffmpeg-devel] Network patch for MingW users

[Måns Rullgård]

Michel Bardiaux said:
> M?ns Rullg?rd wrote:
>> Michel Bardiaux said:
>>> M?ns Rullg?rd wrote:
>>>> Michel Bardiaux said:
>>>>> Fran?ois Revol wrote:
>>>>> [snip]
>>>>>
>>>>>>>> +#ifdef __MINGW32__
>>>>>>>> +    init_winsock();
>>>>>>>> +#endif
>>>>>>> Aaaaiiiieeee!  NO MORE OF THIS. PLEASE.
>>>>>> Also that's totally definitely non threadsafe.
>>>>> Why? AFAIK WSAStartup is threadsafe. See e.g.
>>>>> http://www.tangentsoft.net/wskfaq/
>>>> Of more interest is what happens if WSAStartup() is called more than once.
>>>> Likewise for WSACleanup()
>>>>
>>> What do you mean by that? That WSAStartup should not be called more than
>>> once? It can.
>>
>> Good.  I wasn't sure.  Do calls to WSAStartup/WSACleanup nest properly too?
>>
> Not sure what you mean by 'nest'. The MS docs state that for each
> WSAStartup there must be exactly one WSACleanup, but only the last one
> will actually cleanup anything.

Fine, that's what I meant.  You just can't be too careful when dealing with
windows stuff.

-- 
M?ns Rullg?rd
mans at mansr.com