[Ffmpeg-devel] swscaler equivalent to img_convert

[Michael Niedermayer]

Hi

On Sun, Feb 18, 2007 at 09:45:02PM +0100, GizmoSDK wrote:
> >>
> >>I think it would be good to have a compatible img_convert implemented
> >>with swscaler when the --enable-swscaler is used. I think there are a
> >>coule of important issues to be solved.
> >>
> >>1. img_convert should have a equiv implementation with sws_scale so
> >>you can build compatible builds with or without --enable-swscaler
> >
> >you can use swscale even if its disabled, it will use img_convert then
> >see ffmpeg.c
> 
> yes, but the result will be different as alphas are set to 0xff
> 
> >
> >
> >>
> >>2. The alpha values of sws_ routines should be set to 0xff when
> >>creating alpha values out of non alpha source pixel formats as this
> >>describes the opacity in most cases.
> >
> >send patch and benchmark and we can disscuss it, i wont agree to this
> >without knowing what effect it has on speed
> 
> ok.
> 
> patch is attached. It has the same timing cycles as the previous code  
> but the alpha set to 0xff instead

this changes just one single converter which makes the output inconsistant
theres non mmx code, there are rgb->rgb converters, ...


[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Let us carefully observe those good qualities wherein our enemies excel us
and endeavor to excel them, by avoiding what is faulty, and imitating what
is excellent in them. -- Plutarch
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20070218/6b0ea8a2/attachment.pgp>