[Ffmpeg-devel] [RFC] [PATCH] FLC/FLX/DTA encoder

[Måns Rullgård]

Alex Beregszaszi <alex at fsn.hu> writes:

> Hi,
>
> attached is a huge patch adding three decoders: FLC, FLX and DTA.
>
> FLC is the 8bit RLE based format, FLX supports 15bits, while DTA adds
> new compression methods to FLX.
>
> The IFR (interframe reoder) code in palette.c reorders a frame in order
> to achieve only palette changes, thus possibly never emit any newly
> coded frames, but only palette differences. It is used in the encoder.
>
> Known:
> * current patch has hard tabs and maybe identation issues (but any
> cosmetic recommendations are welcomed)

Why don't you do something about that?  You know what the rules are.

> Question:
> * should it be splitted into flicenc.c ?

Yes.  How different are FLC, FLX and DTA?  Perhaps even they should be
separated.  If they share enough code (I haven't looked closely) to
warrant being in the same file, they should still have #ifdefs to
allow individual selection.

The decoder can be renamed to flicdec.c separately.

-- 
M?ns Rullg?rd
mans at mansr.com