[Ffmpeg-devel] [PATCH] let ffplay can play more pixel format

[Michael Niedermayer]

Hi

On Thu, Feb 15, 2007 at 10:22:31AM +0800, Limin Wang wrote:
> Hi,
> 
> * Michel Bardiaux <mbardiaux at mediaxim.be> [2007-02-14 12:19:45 +0100]:
> 
> > Limin Wang wrote:
> > >Hi there,
> > >
> > >It's very useful to preview the raw video by ffplay I think. The patch
> > >will support ffplay to play yuv422p, yuv444p, etc instead of yuv420 only.
> > >Please review it.
> > >
> > >* How to test it:
> > >lmwang at laptop:~/yuvad/open/h264/x264$ ./x264 --progress --frames 100 -o
> > >/tmp/foremean_cif.h264 /home/lmwang/download/test_sequence/foreman_cif.yuv
> > >352x288
> > >lmwang at laptop:~/yuvad/open/h264/ffmpeg$ ./ffmpeg -i /tmp/foreman_cif.h264
> > >-pix_fmt yuv422p /tmp/2.yuv
> > >lmwang at laptop:~/yuvad/open/h264/ffmpeg$ ./ffplay -x 352 -y 288 -pix_fmt
> > >yuv422p /tmp/2.yuv
> > 
> > Now might be a good time to add a -s WxH to ffplay too, and stop abusing 
> > -x -y which have not been intended for giving the wxh of rawvideo.
> 
> Have add -s WxH option, please review the new patch. training white space has
> been deleted also.
> 
> 
> > > 
> > >In addition, how about to add -pix_fmt help option for ffmpeg and ffplay? 
> > >It's
> > >very crazy to find out what's the pixel format name from the code.
> > >
> > 
> > 
> > 
> > -- 
> > Michel Bardiaux
> > R&D Director
> > T +32 [0] 2 790 29 41
> > F +32 [0] 2 790 29 02
> > E mailto:mbardiaux at mediaxim.be
> > 
> > Mediaxim NV/SA
> > Vorstlaan 191 Boulevard du Souverain
> > Brussel 1160 Bruxelles
> > http://www.mediaxim.com/
> > _______________________________________________
> > ffmpeg-devel mailing list
> > ffmpeg-devel at mplayerhq.hu
> > http://lists.mplayerhq.hu/mailman/listinfo/ffmpeg-devel

[...]
>      if (err < 0) {
> @@ -2335,8 +2339,20 @@
>      }
>  }
>  
> -void opt_width(const char *arg)
[...]
> +static void opt_width(const char *arg)
> +{
>      screen_width = atoi(arg);
>      if(screen_width<=0){
>          fprintf(stderr, "invalid width\n");
> @@ -2344,7 +2360,7 @@
>      }
>  }
>  
> -void opt_height(const char *arg)
> +static void opt_height(const char *arg)


> -void opt_seek(const char *arg)
> +static void opt_seek(const char *arg)

unreleated changes

except these the patch should be ok

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Good people do not need laws to tell them to act responsibly, while bad
people will find a way around the laws. -- Plato
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20070216/b093d042/attachment.pgp>