[Ffmpeg-devel] [PATCH] Print KB for 1024 bytes

[Panagiotis Issaris]

Hi,

Michel Bardiaux schreef:
> Panagiotis Issaris wrote:
>> M?ns Rullg?rd schreef:
>>> Michel Bardiaux said:
>>>> For consistency with command line options
>>> Rejected.  The standard abbreviation for kilo is a lowercase k.
> 
> For kilo-1000 or kilo-1024? Currently, in the *same* message, k in kB
> means 1024 and k in kbits/sec means 1000. They cant both be right!
No, it was intended that k should only mean 1000, not 1024. When 1024 is
meant, kiB should be used instead.

    101                 if(next[1] == 'i'){
    102                     d*= pow( 2, e/0.3);
    103                     next+=2;
    104                 }else{
    105                     d*= pow(10, e);
    106                     next++;
    107                 }

But, this ofcourse only affects input not output... And apparantly you
are right in that the output of ffmpeg.c is inconsistent.

>> Yes, and in fact, the command line options use 'k' (although they also
>> allow 'K').
> 
> They use k for 1000. I wish they wouldnt allow K for 1000, but at least
> I have a choice of not using it. Output is another matter.
Yes, I'd suggest applying one of the attached patches.

With friendly regards,
Takis
-------------- next part --------------
A non-text attachment was scrubbed...
Name: pi-20070215T134431-ffmpeg-si_units.diff
Type: text/x-patch
Size: 1495 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20070215/1f0db5df/attachment.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: pi-20070215T134532-ffmpeg-si_units_2.diff
Type: text/x-patch
Size: 1479 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20070215/1f0db5df/attachment-0001.bin>