[Ffmpeg-devel] [PATCH] Add fact chunk to non-PCM wav

[Michael Niedermayer]

Hi

On Mon, Feb 12, 2007 at 03:30:39PM +0100, Michel Bardiaux wrote:
[...]
> >hmm indeed, sorry, but i still would suggest
> >
> >if(pkt->pts != AV_NOPTS_VALUE){
> >    context->maxpts= FFMAX(context->maxpts, pkt->pts);
> >    context->minpts= FFMAX(context->minpts, pkt->pts);
> >}else
> >    av_log(s, AV_LOG_INFO, "wav_write_packet: NOPTS\n");
> 
> Fine.
> 
> Revised patch attached (as I said before, without regression fixes, I 
> will add them as soon as this is nihil obstat).
> 
> >>BTW I feel that the 'assert' should be hunted down even more ruthlessly 
> >>as the dprintf. What do you think?
> >
> >some asserts are inappropriate they surely should be hunted down, others
> >are valid and should not
> 
> I meant 'hunt assert to replace it by if+av_log+appropriate rror 
> return'. Most people 'configure' in such a way that 'assert' is a nop. 

and correct asserts should never be false so a nop is all fine of course
one checking function parameters from exported functions is not correct ...


> But maybe this should be shifted to a new thread?

yes

patch looks ok except that minpts should be initalized to INT64_MAX it
does nothing otherwise

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

I have never wished to cater to the crowd; for what I know they do not
approve, and what they approve I do not know. -- Epicurus
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20070212/8b58aa9e/attachment.pgp>