[Ffmpeg-devel] [PATCH] Remove INT64_C from "common.h"

Alexander Chemeris ipse.ffmpeg
Sun Feb 11 20:15:47 CET 2007


Hello,

INT64_C macro is defined in <stdint.h>, according to paragraph 7.18.4.1
of C99 standard. I belive it should be removed from "common.h" include,
because it is system dependent. E.g. under MS Visual Studio it should
be defined as

#define INT64_C(val) val##i64

However I should note, that if ffmpeg public headers will be used with C++
compiler, then __STDC_CONSTANT_MACROS preprocessor define
should be defined before first use of <stdint.h>, according to footnote 224
at page 260 of C99 standard. It's your choice - define it in "common.h"
just before <inttypes.h> include, or leave it undefined. In later case it would
be good to add note to FAQ about this issue.


--
Regards,
Alexander Chemeris.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: int64_c.patch
Type: application/octet-stream
Size: 484 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20070211/bc9ff38e/attachment.obj>



More information about the ffmpeg-devel mailing list