[Ffmpeg-devel] [PATCH] updated LGPL AC-3 decoder

[Diego Biurrun]

On Sun, Feb 11, 2007 at 03:38:41PM +0000, M?ns Rullg?rd wrote:
> Diego Biurrun <diego at biurrun.de> writes:
> 
> > On Sun, Feb 11, 2007 at 01:52:46PM +0000, M?ns Rullg?rd wrote:
> >> Diego Biurrun <diego at biurrun.de> writes:
> >> 
> >> > On Sun, Feb 11, 2007 at 01:17:09PM +0100, Michael Niedermayer wrote:
> >> >> 
> >> >> On Sun, Feb 11, 2007 at 12:15:25PM +0100, Diego Biurrun wrote:
> >> >> > On Sun, Feb 11, 2007 at 01:13:46AM +0100, Michael Niedermayer wrote:
> >> >> > > 
> >> >> > > On Sat, Feb 10, 2007 at 10:07:40PM +0100, Diego Biurrun wrote:
> >> >> > > > 
> >> >> > > > So do I have your blessing for removing the internal liba52?
> >> >> > > 
> >> >> > > all files except thouse written by me (as the mmx/sse code in them might
> >> >> > > be usefull for the new decoder ...)
> >> >> > 
> >> >> > That would be the file resample_mmx.c, it's the only one that has your
> >> >> > name in the copyright notice.  However, this file is also present in
> >> >> > MPlayer's copy of liba52.  MPlayer's copy contains further interesting
> >> >> > changes like AMD64 support, so I think that's a better reference.
> >> >> > 
> >> >> > OK to remove resample_mmx.c as well then?
> >> >> 
> >> >> ok
> >> >
> >> > OK, I'm going to remove it soon then.  IIUC this requires a major
> >> > version bump.  The problem is that avcodec_decode_audio is marked
> >> > deprecated and will be removed by the preprocessor once the the
> >> > libavcodec major version reaches 52.
> >> 
> >> Why would this need a version bump?  There is no API or ABI change.
> >
> > The last time we talked about this Michael said a version bump would be
> > necessary since this removes a feature from libavcodec..
> 
> As I understood it, the intention was to remove the internal liba52
> and continue linking to it externally.

Yes, at least for the moment.  libavcodec/a52dec.c would remain with the
LIBA52BIN #ifdefs removed.

> Especially considering that it always required an explicit
> --enable-a52, I don't see the need for a version bump.

Well, I'll be happy to skip this step since it makes my life easier.
Michael?

Diego