[Ffmpeg-devel] [PATCH] New grabbing interface

[Michael Niedermayer]

Hi

On Wed, Feb 07, 2007 at 11:29:51PM -0200, Ramiro Polla wrote:
> Hello,
> 
> Michael Niedermayer wrote:
> >Hi
> >
> >On Wed, Jan 31, 2007 at 05:56:29PM -0200, ramiro at lisha.ufsc.br wrote:
> >  
> >>Hello,
> >>
> >>New grabbing interface, with suggestions from Michael, Mans and Michel, as
> >>discussed throughout this thread:
> >>http://news.gmane.org/find-root.php?message_id=%3c1144.200.174.46.72.1169408422.squirrel%40mail.lisha.ufsc.br%3e
> >>
> >>It removes all "default grabbing". You must now specify the format and the
> >>input. Docs updated accordingly.
> >>
> >>Tested with video4linux2 and X11.
> >>    
> >
> >video4linux1 must be tested too
> >also video + audio grabing especially AV-sync must be tested (test old and 
> >new
> >and ensure that both are fine and that the new code doesnt cause more 
> >frames
> >to be droped (ffmpeg -v 9))
> >  
> >  
> [...]
> >>It's not used anymore
> >>(it was only by prepare_grab, and not by -grab), but I don't know if I
> >>should adapt it or remove it.
> >>    
> >
> >the new grab code should use it (if more then one grabing thingy is used
> >then it should be 1)
> >
> >  
> 
> Two choices attached:
> grabbing_interface_1.diff makes input_sync an option (-isync).
> grabbing_interface_2.diff adds a flag to AVFMT and sets input_sync if 
> any grabbing interface is selected.
> 
> Both patches pass regressions tests.
> 
> Tests made against unpatched FFmpeg.
> 
> video4linux + audio:
> Same results with second patch.
> Same results with first patch using -isync.
> Bad results with first patch not using -isync. Fewer video frames (now I 
> know why input_sync was added in the first place =).
> 
> video4linux2 + audio:
> Same results with second patch.
> Same results with first patch using -isync.
> I didn't notice any difference with the first patch not using -isync. 
> (This is probably what Luca mentioned).
> 
> x11grab + audio:
> Always same results.

patch 1 looks ok

[...]

-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

It is dangerous to be right in matters on which the established authorities
are wrong. -- Voltaire
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20070208/3391d1b1/attachment.pgp>