[Ffmpeg-devel] [PATCH] movenc should set depth in stsd atom

[Michael Niedermayer]

Hi

On Wed, Feb 07, 2007 at 09:59:39PM +0100, Reimar D?ffinger wrote:
> Hello,
> On Wed, Feb 07, 2007 at 09:34:51PM +0100, Baptiste Coudurier wrote:
> > Reimar D?ffinger wrote:
> > > have not actually tested it, but since the demuxer reads bits_per_sample
> > > from that field I would expect it makes sense to write it there in the
> > > muxer...
> > > Comments?
> > 
> > Check that this is right for 3gp/mp4, I doubt it.
> > Also, does it work for correctly stream copy ? (ps->mov, avi->mov)
> 
> No idea, not really interested enough in it to check, someone on irc
> was working on qtrle encoder and this caused problems.
> Though I am really sure that current code breaks mov->mov stream copy of
> non-24-bit qtrle

well someone has to check the mp4 spec before this can be applied, iam
also guessing that your proposal is wrong for .mp4 (no i wont look at the
mp4 spec today, maybe next year ...)

[...]

-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

No great genius has ever existed without some touch of madness. -- Aristotle
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20070207/5e4473e0/attachment.pgp>