[Ffmpeg-devel] [PATCH] wrong use of ff_get_fourcc in mpjg.c

Michael Niedermayer michaelni
Wed Feb 7 18:36:43 CET 2007


Hi

On Wed, Feb 07, 2007 at 06:00:00PM +0100, Reimar D?ffinger wrote:
> Hello,
> On Wed, Feb 07, 2007 at 01:45:25PM -0000, M?ns Rullg?rd wrote:
> > Reimar Doeffinger said:
> [...]
> > > AV_RB32 etc. in general when there are optimized variants maybe not, but a macro
> > > that expands to
> > > ("ABCD")[0] | (("ABCD")[1] << 8) ...
> > > I'd expect to resolve to a constant...
> > 
> > Well, it doesn't.  Believe me, I've tried it.
> 
> Maybe your info is outdated?
> It does for me with gcc 4.1.1 and starting from -O1.

well, but is it valid C ? if not this disscussion is useless ...

except that gcc shouldnt compile invalid code and OTOH should compile
valid code independant of the -O parameter ...

[...]

-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

I do not agree with what you have to say, but I'll defend to the death your
right to say it. -- Voltaire
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20070207/2b18bf77/attachment.pgp>



More information about the ffmpeg-devel mailing list