[Ffmpeg-devel] [PATCH] fix av_log_set_level undefined

Benoit Fouet benoit.fouet
Wed Feb 7 12:09:05 CET 2007


Limin Wang wrote:
> Hi,
>
> * Luca Abeni <lucabe72 at email.it> [2007-02-07 10:55:50 +0100]:
>
> > Hi Guillaume,
>
> > On Wed, 2007-02-07 at 10:32 +0100, Guillaume POIRIER wrote:
> > [...]
> >>> I think av_log_get/set_level is useful function and
> >>> shouldn't depend on LIBAVUTIL_VERSION_INT version.
> >>> The attached patch try to fix compile failed after
> >>> LIBAVUTIL_VERSION_INT increased.
> >> I confirm that this patch fixes compilation failure.
> >>
> >> Is it good to go Michael?
> > I am not Michael, but I seem to remember the discussion that originated
> > the removal of av_log_{get,set}_level().
> > I think Michael wanted to remove such functions by exporting
> > av_log_level and directly accessing it.
>
> > If my understanding is correct, the attached patch might be a better
> > solution.
>
> I prefer to using av_log_{get,set}_level() instead of using global
> variable.
> If want to keep them, then av_log_level should be defined as static.
>  
>
> Thanks,
> Limin
indeed, this is fixed by latest delivery by Diego (r7868)

Ben





More information about the ffmpeg-devel mailing list