[Ffmpeg-devel] [PATCH] access all bitrates for amr nb encoding

[Benoit Fouet]

Michael Niedermayer wrote:
> Hi
>
> On Tue, Feb 06, 2007 at 12:08:49PM +0100, Benoit Fouet wrote:
>   
>> Michael Niedermayer wrote:
>>     
>>> Hi
>>>
>>> On Tue, Feb 06, 2007 at 09:54:10AM +0100, Benoit Fouet wrote:
>>>   
>>>       
>>>> Hi,
>>>>
>>>> Michael Niedermayer wrote:
>>>>     
>>>>         
>>>>> all wrong the whole funtion and audio_bit_rate must be removed from ffmpeg.c
>>>>> see svn log about the similar change done with the video bitrate
>>>>>
>>>>> [...]
>>>>>   
>>>>>   
>>>>>       
>>>>>           
>>>> well, i'm coming with the beginning of something...
>>>> the problem is that audio and video bitrate are crushing one another...
>>>>
>>>> for instance launching a ffmpeg with a -b and -ab options, the last of
>>>> the two options will be taken into acount...
>>>> the question is: "is it the right place to add the ab option handling ?"
>>>>     
>>>>         
>>> hmm avctx_opts in ffmpeg.c should maybe be split
>>>
>>> [...]
>>>   
>>>   
>>>       
>> one for video, and one for audio ?
>>     
>
> yes, we can add one for subtitles later when it becomes needed, there
> are also many other possible solutions, like writing the options directly
> into the target context with no avctx_opts in between ...
>
>
>   
indeed, i tried to understand how all this option stuff worked, and it
seems a bit obscure to me for the moment...
if we want to split audio and video avctx_opts, for instance, we'll have
to split the "default" handling too, am i right ?
anyway, i think i'm going to go on reading the source and try to find
out how this is done...

Ben