[Ffmpeg-devel] [PATCH] access all bitrates for amr nb encoding

[Benoit Fouet]

Michael Niedermayer wrote:
> Hi
>
> On Fri, Feb 02, 2007 at 03:49:12PM +0100, Benoit Fouet wrote:
>   
>> Hi,
>>
>> attached a patch to allow using 7,4kbps bitrate when encoding amr_nb files.
>>     
>
> i do not know the correct bitrate values but the table should contain
> the correct bitrates, i assume that its cbr so ranges are never correct
> if the user selects a not supported bitrate then this should lead to a
> hard failure not a different bitrate also if any exact bitrates cannot
> be selected then thats a bug which should be fixed instead of being
> worked around by changing the bitrate table
>
> [...]
>   
ok. if i understand correctly then, we have to fix the value which is
given to the encoder.
the -ab option is in kbits/s, so it is not possible for the moment to
give the proper bitrate to the encoder.
i don't know where is the good place to fix it, though.
i also think this would have a high impact to give the bitrate in bits/s
another way to do it could be to compute the bitrate differently in amr
codec, like dividing by 1000 the value that is given, and then find if
it matches exactly one of the possible values...

please let me know what you prefer

Ben