[FFmpeg-devel] [PATCH] rtsp - alternate protocol

Michael Niedermayer michaelni
Fri Dec 28 19:28:21 CET 2007


On Fri, Dec 28, 2007 at 06:42:29PM +0100, Luca Abeni wrote:
> Hi Michael,
>
> Michael Niedermayer wrote:
> [...]
>> either way rtsp_default_protocols should be droped its redundant and a 
>> mess
>> also it doesnt work on some OSs with PIC after -Bsymbolic has been added,
>> not that it did work before on all ...
>> Thats of course unrelated to the patch but the patch depends on 
>> rtsp_default_protocols which shouldnt be there at all ...
> I have a patch removing rtsp_default_protocols... I did not submit it 
> before because it is missing the ffplay part (I just added in this moment 
> the minimal changes needed to compile ffplay).
>
> The patch removes rtsp_default_protocols, fixes option parsing in rtsp.c 
> (otherwise it would be impossible to select rtp over tcp), and removes 
> rtsp_default_protocols usage from ffplay.c.
>
> If the patch is ok, I can commit it in three times (first fix option 
> parsing, then remove rtsp_default_protocols usage from ffplay, and then 
> remove such variable from rtsp.c).


patch ok if the following hunk is intended

[...]

> @@ -864,7 +859,7 @@
>          port = RTSP_DEFAULT_PORT;
>  
>      /* search for options */
> -    option_list = strchr(path, '?');
> +    option_list = strchr(s->filename, '?');
>      if (option_list) {
>          /* remove the options from the path */
>          *option_list++ = 0;


[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

I am the wisest man alive, for I know one thing, and that is that I know
nothing. -- Socrates
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20071228/76bf1e2d/attachment.pgp>



More information about the ffmpeg-devel mailing list