[FFmpeg-devel] [PATCH] fix clicking sound in xa-adpcm

[Rich Felker]

On Thu, Dec 27, 2007 at 03:20:24AM -0500, Alexander Strange wrote:
> 
> On Dec 8, 2007, at 6:13 PM, Michael Niedermayer wrote:
> 
> > On Wed, Dec 05, 2007 at 11:32:53AM -0500, Alexander Strange wrote:
> >> The XA ADPCM decoder resets the last sample predictors to 0 after  
> >> every
> >> frame.
> >> This is wrong, and causes loud clicking constantly in all my samples.
> >> Attached patch fixes it.
> >
> > patch is probably ok
> 
> Ping; does anyone else have a problem with it?
> I think it wouldn't be any worse than missing the bit reservoir in mp3,
> in a perfect world where it could seek in this format in the first  
> place.

Dropping the bit reservoir once at the beginning of decoding mp3 will
not cause any major problem. Dropping it on every frame would create
horrible ear-grating artifacts, perhaps clicking or otherwise.

Rich