[FFmpeg-devel] [PATCH 01/N] RV30/40 Decoder - Core

[Michael Niedermayer]

On Thu, Dec 13, 2007 at 09:46:33AM +0200, Kostya wrote:
> On Sun, Dec 09, 2007 at 02:47:36PM +0100, Michael Niedermayer wrote:
> [...]
> > > > 
> > > > fill_rectangle() should be used here, yes please
> > > > move fill_rectangle() into a file from where it can be used, its a very
> > > > usefull function
> > > 
> > > I guess it should be moved to h264.h. I will try to use it where appropriate.
> > 
> > i dont think it should be moved to h264.h its not h264 specific
> 
> Then it's up to you to decide where place it.

rectangle.h would do for now


> 
> [...]
> 
> Here is a new revision which relies on fill_rectangle()
> (mostly for availability cache filling).

ok, ill wait until you took care of all review comments before reviewing
again

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

The worst form of inequality is to try to make unequal things equal.
-- Aristotle
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20071213/253d18a0/attachment.pgp>