[FFmpeg-devel] [FFmpeg-cvslog] r11100 - in trunk/libavcodec/i386: cavsdsp_mmx.c dsputil_mmx.c dsputil_mmx.h h264dsp_mmx.c mpegvideo_mmx.c vc1dsp_mmx.c

Rich Felker dalias
Sat Dec 1 16:14:07 CET 2007


On Sat, Dec 01, 2007 at 02:00:57AM +0200, Uoti Urpala wrote:
> visibility you want to change. Basically you'd have 'static' for things
> visible only in the same translation unit, and 'FF_PRIVATE' (or some

I absolutely HATE programs that do things like this, simply because
one cannot tell immediately from reading the code what the effect is.
You have to dig thru multiple levels of nested includes to find out
what the special name means.

I'm absolutely against anything related to gcc visibility crap, also.
That [mis]feature should be taken out back...

> -Bsymbolic is "simpler" of course but it does not achieve the same
> things.

It achieves the only thing which is important here, working around the
binutils bug without polluting the codebase.

Rich




More information about the ffmpeg-devel mailing list