[FFmpeg-devel] [PATCH 00/N] RV30/40 decoder - VLC tables

Vitor Sessak vitor1001
Sat Dec 1 14:54:44 CET 2007


Hi

Just two small nitpickings...

Kostya Shishkov wrote:
> Here is VLC table used by decoder core.

>  * copyright (c) 2007 Konstantin Shishkov

I think "Copyright" with the first C capitalized is preferred.

[...]


> static const uint8_t rv34_table_inter_firstpat[NUM_INTER_TABLES][2][FIRSTBLK_VLC_SIZE] = {
>   {
>     {
>        0,  7,  5,  7,  5,  7,  6,  6,  7, 10,  7,  9,  8,  9,  8,  7,
>       12, 14, 11, 12, 12, 12, 11,  9,  6,  9,  6,  8,  7,  9,  7,  7,
>        8, 11,  8,  9,  9, 10,  9,  8, 13, 15, 12, 12, 12, 13, 11,  9,
>       10, 13,  9, 10, 11, 12,  9,  8, 12, 14, 10, 11, 12, 13, 10,  9,
>       16, 16, 12, 12, 14, 13, 11,  9,  6,  9,  7,  9,  7,  9,  8,  7,

[...]

> 
>       14, 16, 13, 13, 11, 12, 10,  9, 16, 16, 14, 13, 13, 13, 11,  8,
>       13, 16, 12, 13, 11, 12, 10,  9, 14, 16, 13, 13, 12, 12, 10,  9,
>       16, 16, 14, 13, 13, 12, 10,  8, 14, 16, 12, 12, 12, 13, 10,  8,
>       14, 16, 12, 12, 12, 13, 10,  7, 16, 16, 11, 11, 12, 11,  8,  5,
> 
>     },
>     {

The empty line is inconsistent with the rest of the indentation.

-Vitor





More information about the ffmpeg-devel mailing list