[FFmpeg-devel] [PATCH]pes packetizer

[Michael Niedermayer]

Hi

On Fri, Aug 31, 2007 at 07:32:54PM +0800, Xiaohui Sun wrote:
> Diego Biurrun wrote:
> > On Fri, Aug 31, 2007 at 07:09:41PM +0800, Xiaohui Sun wrote:
> >   
> >> Diego Biurrun wrote:
> >>     
> >>> On Fri, Aug 31, 2007 at 05:43:35PM +0800, Xiaohui Sun wrote:
> >>>   
> >>>       
> >>>> [...]
> >>>>         
> >>> The main complaint was that you should split your patch into several
> >>> more manageable and separate parts.  But you send in another 66kB beast.
> >>> Either I am missing something (well possible, I didn't check in detail)
> >>> or you should start sending in small pieces.
> >>>       
> >> split a file into two files will cause the patch approximately two times 
> >> the original files (mpegenc.c is 40k)
> >> should I put the modification of each file(mpegenc.c mpeg_pes_enc.c 
> >> Makefile mpeg_pes.h) into different patches, but that
> >> seems meaningless to each patch and could not be compiled :-(
> >>     
> >
> > I'll try to say things more clearly: If the function renaming and the
> > cosmetics can be applied first, then you should send these in
> > separately.
> >
> >   
> what about first send/apply the main patch(split) then send the 
> cosmetics and renamings,
> and that would be more readable IMHO

the intermediate would have global functions with no proper ff_ prefix

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

I count him braver who overcomes his desires than him who conquers his
enemies for the hardest victory is over self. -- Aristotle
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20070831/932d002d/attachment.pgp>