[FFmpeg-devel] [PATCH]pes packetizer

Diego Biurrun diego
Fri Aug 31 13:19:03 CEST 2007


On Fri, Aug 31, 2007 at 07:09:41PM +0800, Xiaohui Sun wrote:
> Diego Biurrun wrote:
> > On Fri, Aug 31, 2007 at 05:43:35PM +0800, Xiaohui Sun wrote:
> >   
> >> [...]
> >
> > The main complaint was that you should split your patch into several
> > more manageable and separate parts.  But you send in another 66kB beast.
> > Either I am missing something (well possible, I didn't check in detail)
> > or you should start sending in small pieces.
> 
> split a file into two files will cause the patch approximately two times 
> the original files (mpegenc.c is 40k)
> should I put the modification of each file(mpegenc.c mpeg_pes_enc.c 
> Makefile mpeg_pes.h) into different patches, but that
> seems meaningless to each patch and could not be compiled :-(

I'll try to say things more clearly: If the function renaming and the
cosmetics can be applied first, then you should send these in
separately.

Diego




More information about the ffmpeg-devel mailing list