[FFmpeg-devel] [PATCH] Don't let ctx->skip_frame>0 produce errors

[Carl Eugen Hoyos]

Hi!

On 2007-08-30 16:28, Michael Niedermayer wrote:

[...]

> > > well but what if
> > > avctx->skip_frame>0
> > > and this code is reached for a reason different then skip_frame ?
> >
> > Then the user silenced an error by disabling complete decoding.
> > Or is there a better solution? More different return values for
> > decode_nal_units() only make the code messier, don't you think?
> 
> also
> if( (s->hurry_up == 1 && h->nal_ref_idc == 0) //FIXME do not discard SEI id
> ||(avctx->skip_frame >= AVDISCARD_NONREF && h->nal_ref_idc == 0))
> continue;
> 
> your code hides the warning only in one of the 2 cases

I was under the obviously wrong impression that deprecated features are
not considered when doing such a change.

New patch attached, Carl Eugen
-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: patchskipframe
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20070830/a33753da/attachment.asc>