[FFmpeg-devel] MPEG Video support in RTP

Luca Abeni lucabe72
Tue Aug 28 21:36:57 CEST 2007


Hi Luca,

On Tue, 2007-08-28 at 16:31 +0200, Luca Barbato wrote:
[...]
> Obviously I messed up adding minimal fixes for the issue... (yesterday I
> was busy writing some documentation and wasn't using my laptop those
> emails got unread till now)

Ok; I updated the first two patches of my series to apply after your
changes
I also changed fix_packetization.diff according to your feedback.

[...]
> +    max_packet_size = s->max_payload_size - 4; /* 4 bytes for the
> payload header */
> +                            len = r - buf1 - 4;
> +                            len = r1 - buf1 - 4;
> 
> the -4 could be factorized to the end

I suspect this will not increase the code readability... So, I did not
put this change in fix_packetization.diff, but I created a new patch
(factorize-4.diff) for it. If you still think this change is needed,
I'll apply factorize-4.diff after fix_packetization.diff


			Thanks,
				Luca
-------------- next part --------------
A non-text attachment was scrubbed...
Name: fix_packetization.diff
Type: text/x-patch
Size: 2478 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20070828/94e6d0f2/attachment.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: factorize-4.diff
Type: text/x-patch
Size: 1661 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20070828/94e6d0f2/attachment-0001.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: remove_header_extension.diff
Type: text/x-patch
Size: 762 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20070828/94e6d0f2/attachment-0002.bin>



More information about the ffmpeg-devel mailing list