[FFmpeg-devel] [PATCH] h264 luma interpolation 8x8 for altivec

[Guillaume POIRIER]

Hi,

On 8/25/07, Luca Barbato <lu_zero at gentoo.org> wrote:
> Guillaume POIRIER wrote:
> > Hi,
> >
> > On 8/12/07, Guillaume POIRIER <poirierg at gmail.com> wrote:
> >
> >> IMHO, it would be a good idea to add a code to allow an easy test of
> >> these alignment thingies in case we need to do some debug.
> >>
> >> I'd like to add smth like this
> >> #ifdef DEBUG_ALIGNMENT
> >> #define ASSERT_ALIGNED(ptr) assert(!((unsigned long)ptr&0x0000000F));
> >> #else ASSERT_ALIGNED(ptr) 0;
> >> #endif
> >>
> >> and add ASSERT_ALIGNED() wherever we were handling unaligned memory accesses.
> >>
> >> That way, if for some reason a user experiences corruptions, we can
> >> advise him to test for alignment by defining DEBUG_ALIGNMENT.
> >>
> >> So, what do you guys think?
> >
> > Like in attached patch...
> >
> > Does this look reasonable?
>
> 1/16 you'd get things as you expect even if they are wrong. It isn't
> exactly something I'd use.

So no assert or guards at all, just the original patch?

Guillaume
-- 
A soldier will fight long and hard for a bit of colored ribbon.
 -- Napoleon Bonaparte