[FFmpeg-devel] [PATCH] add AVCodecContext field to specify desired number of channels

[Benoit Fouet]

Michael Niedermayer wrote:
> Hi
>
> On Mon, Aug 20, 2007 at 11:28:37PM +0200, Reimar D?ffinger wrote:
>   
>> Hello,
>> On Mon, Aug 20, 2007 at 09:20:29PM +0100, M?ns Rullg?rd wrote:
>>     
>>> Reimar D?ffinger <Reimar.Doeffinger at stud.uni-karlsruhe.de> writes:
>>>       
>>>> On Mon, Aug 20, 2007 at 07:37:47PM +0200, Michael Niedermayer wrote:
>>>>         
>>>>> On Mon, Aug 20, 2007 at 04:53:26PM +0200, Reimar D?ffinger wrote:
>>>>>           
>> [...]
>>     
>>>>>> @@ -753,6 +753,7 @@ static const AVOption options[]={
>>>>>>  {"timecode_frame_start", "GOP timecode frame start number, in non drop frame format", OFFSET(timecode_frame_start), FF_OPT_TYPE_INT, 0, 0, INT_MAX, V|E},
>>>>>>  {"drop_frame_timecode", NULL, 0, FF_OPT_TYPE_CONST, CODEC_FLAG2_DROP_FRAME_TIMECODE, INT_MIN, INT_MAX, V|E, "flags2"},
>>>>>>  {"non_linear_q", "use non linear quantizer", 0, FF_OPT_TYPE_CONST, CODEC_FLAG2_NON_LINEAR_QUANT, INT_MIN, INT_MAX, V|E, "flags2"},
>>>>>> +{"request_channels", "set desired number of audio channels", OFFSET(request_channels), FF_OPT_TYPE_INT, DEFAULT, INT_MIN, INT_MAX, A|D},
>>>>>>             
>>>>> i think the max/min can be improved
>>>>> 5000 channels is not sane neither is -3 channels
>>>>>           
>>>> I agree, but I didn't want to "invent" some numbers and those are the
>>>> values that are used for "channels".
>>>>         
>>> I think you can safely exclude negative numbers.  Choosing an upper
>>> limit is admittedly more arbitrary.
>>>       
>> sure, 0 instead of INT_MIN then. Is INT_MAX okay? And is there any
>>     
>
> well id set max to 100 or so ...
>
>
>   

i don't see why 100 is better than INT_MAX.
why do you want to choose an arbitrary value ?

-- 
Ben
Purple Labs S.A.
www.purplelabs.com