[FFmpeg-devel] [PATCH] add AVCodecContext field to specify desired number of channels

Michael Niedermayer michaelni
Mon Aug 20 13:57:57 CEST 2007


Hi

On Sun, Aug 19, 2007 at 10:08:13PM +0200, Michael Niedermayer wrote:
> Hi
> 
> On Sun, Aug 19, 2007 at 04:56:44PM +0200, Reimar D?ffinger wrote:
> > Hello,
> > since the current way of setting ->channels no matter how it is done
> > will break some codecs I suggest adding a new field.
> > Also has the advantage that it will be easier to allow handling the
> > cases where either the number of desired channels changes or the number
> > of channels in the file changes.
> > I also think that the current behaviour of dca is not good: if it can't
> > deliver the requested number of channels it should just use either
> > something close or the native number instead of failing.
> > Is it right to add this at the end of the context or should it be near
> > "channels"?
> 
> looks ok though maybe you should wait a day or two before applying it
> maybe someone, justin, kostya? have some comments

also dont forget to update the AVOption array un libavcodec/utils.c

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

No great genius has ever existed without some touch of madness. -- Aristotle
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20070820/5ecd4a85/attachment.pgp>



More information about the ffmpeg-devel mailing list