[FFmpeg-devel] Extension of pipe url
Vincent Fourmond
vincent.fourmond
Wed Aug 15 14:28:50 CEST 2007
M?ns Rullg?rd wrote:
> Vincent Fourmond wrote:
>> M?ns Rullg?rd wrote:
>>> And indentation style should be consistent and sane. That is, GNU style
>>> is not tolerable.
>> OK, thanks. Does that look better now ?
>
> The indentation style is still inconsistent.
>
> Furthermore, IMO you should treat things like "10abc" as non-numeric too,
> and not only reject strings not starting with a digit. This is easily
> done as if(*final) since strtol() will set the end pointer pointing at
> the null terminator if the string is all digits.
Yep... You still need the filename == final check to avoid matching
'pipe:'. Here it is, stripped of the last remaining tabs ;-).
Cheers,
Vincent
--
Vincent Fourmond, Doctor in Physics
http://vincent.fourmond.neuf.fr/
-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: pipe_url_extension.3.diff
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20070815/348d964f/attachment.txt>
More information about the ffmpeg-devel
mailing list