[FFmpeg-devel] [PATCH] Use the SDP generator in ffmpeg and ffserver

[Luca Abeni]

Hi Michael,

Michael Niedermayer wrote:
[...]
>> Is the behaviour of ffmpeg_use_sdp_generator.diff ok? (would it be better 
>> to introduce a new command line option for generating an SDP? Would it be 
>> useful to generate an SDP even if the output is not RTP? ...) I implemented 
>> the behaviour that is more useful to me, but if anyone has suggestions I'll 
>> happily modify the patch.
> 
> no clue, id say a command line option which takes a file name and uses '-'
> for stdout might be best

Ok. Is it ok to first commit ffmpeg_use_sdp_generator.diff and then 
implement an "-sdpfile" command line option with a second patch?


> [...]
>> +    if (stream->title[0] != 0) {
>> +        strcpy(avc->title, stream->title);
> 
> av_strlcpy()

Ok. I fixed it in my local copy. BTW, I notice there are some "strcpy()" 
in ffmpeg.c and ffserver.c. Should they be removed? If yes, I'll try to 
submit patches for this in the next weeks.

[...]
> besides these iam fine with the patches though you should wait a day or 2
> before commiting so the ffserver maintainer can comment

Ok; I'll be out of town for some days, so I think I'll commit on next 
Monday (unless someone complains).


			Thanks,
				Luca