[FFmpeg-devel] [PATCH] FLV meta injection(similartoFLVTOOLS2but an addon patch for FFMPEG)

[andrew]

It seems everyone is posting code not in base64, so here is a version of it not base64.

> thanks very much for the tips, Im really glad the mainters are so strict it makes entering a project like this much easier to follow! I now see the mistakes and have modified them. Please find the new base64 encoded patch attached.
> 
> > On Sun, 12 Aug 2007 11:45:08 +0000, andrew scribed:
> > 
> > >Please find the modified patch conforming to the 8.6 and 8.7 rules. If
> > >there are still problem could I have a hint of which rule I have
> > >broken? =) I think I got it all now but perhaps I make mistake, its
> > >the first opensource project i have submitted to.
> > 
> > 
> > thanks for submitting your patch! it is a nice feature but ffmpeg
> > developers are strict about new patches.
> > 
> > 
> > >> > Index: ffmpeg.c
> > >> > ===================================================================
> > >> > --- ffmpeg.c	(revision 10065)
> > >> > +++ ffmpeg.c	(working copy)
> > >> > @@ -33,6 +33,7 @@
> > >> >  #include "opt.h"
> > >> >  #include "fifo.h"
> > >> >  #include "avstring.h"
> > >> > +#include "flvenc.c"
> > >> 
> > >> are you serious?
> > 
> > 
> > michael is saying that ffmpeg.c should not include flvenc.c 
> > figure out how the other options are in the code base and
> > follow that.
> > 
> > 
> > >> [...]
> > >> > @@ -42,6 +42,13 @@
> > >> >  
> > >> >  #define AMF_END_OF_OBJECT         0x09
> > >> >  
> > >> > +#define NUM_OF_ENTRIES 20
> > >> > +
> > >> > +#define AMF_CHILDNODE       3
> > >> > +#define AMF_CHILDNODEVALUE  10
> > >> > +#define AMF_PARENTNODE      9
> > >> > +
> > >> 
> > >> these belong in the enum where the other AMF types are
> > 
> > michael means to put these under line 96 of libavformat/flv.h
> > in that enum with the other AMF types.
> > 
> > -compn
> > _______________________________________________
> > ffmpeg-devel mailing list
> > ffmpeg-devel at mplayerhq.hu
> > http://lists.mplayerhq.hu/mailman/listinfo/ffmpeg-devel
> > 
> 
> Andrew Butkus
> butkus.co.uk
> 
> My public key for contacting me securely:
> 
> -----BEGIN PGP PUBLIC KEY BLOCK-----
> Version: GnuPG v1.4.6 (GNU/Linux)
> 
> mQGiBEa4PeMRBADajg5zW8sM2AkcVfXf/xwKM0mc39MpSLCUwGib5riy4RVpzy4g
> tSvq5s1xpgyaovKiSbRG36PiArrymnHq9O1qCp6+qWqdhaqxuk37LoABQbQ9sXxu
> 0jPYASRN1kTR2tJLklCpmYGvkXPsXe9tx2hBUur6aRbhbkdJyaNCf8JwhwCgkzOC
> ayExrr0DFOiUzXY3XDorFe8EAJgEgIETrS28RHnKh5fOQNp6MYQjmoo7JINXwZTd
> M7WehjbLnytlkBieRAT0Ex8FOesxBS1KkS32xFcN91noiXpOYo/7UcUB1kBXLrdW
> 3FhtGRnBLVMfQljFePhR5BclY/LSKIjwtVBimVd4qQMrYYo3AtGtSz8/VDSSgRlm
> qnADA/44AGz2/qkSormq2aAh7WFGszoAtywc+RTNwskUPboDSfn3cBdmwTcqG2dJ
> K2oiL7HaXuj+Nga8omk4wQdUnig02btc+lLlxkHCW00mfdlblQswpbwEwlZa4Mtl
> hlAreQP1oNTvRcLWPzrC7CqBkOUPxvilipP3c4HWXYrSXsqPGLQ7QW5kcmV3IEJ1
> dGt1cyAoQW5kcmV3J3MgR1BHIGtleSBwYWlyKSA8YW5kcmV3QGJ1dGt1cy5jby51
> az6IYAQTEQIAIAUCRrg94wIbAwYLCQgHAwIEFQIIAwQWAgMBAh4BAheAAAoJENJ5
> Bj3tTq6WEu0AnAsYEPElmoDEzIdbTZJgIWTMeSqdAJ9GrLmAY0fwCyt2l6DC9+IQ
> fGen6rkCDQRGuD3oEAgA714L70CoVgdTphWoza4AW7n4WA7NhgWOsTf/uyV8XV5N
> 6FIvrAWSbueIGnpSYeyEiaQeEsCx5VltWZ5BxxSpWl1vmPwWd5OplUFx2dOpXP+N
> BEghG+StFRVPl350IB3WAvWJHOcbxpWwefnc8kG5GUWZSCY0rrOq4/AZaEdmMwrh
> hMmXUUEJnkO4nLjQgkNIQO9dVzVX+Cm8AuhYqyz2htp7nW6kIq5AFEmk7WZ4PaKZ
> 6fs0KwSF0n978hf8/IprDSNgUOirXtfTxUvB21/lBVY07FrgN5mncKEt1SN3mIny
> ++GYlYFWkPVrT3YAymAxXHFl7kjzki3SE0ugAOrgWwADBgf9E1gK3d9EGmmwAevG
> ZR77toj1kUnkta0ZnnZ0bd+cs9L/VWUBrA4Hk4fsXiLw94yAZyUyMA6topEi7vcD
> JV/hTxtgb+xfnXygdzXtaG3sJlKYOv72aVnvfiELn5lKwOpGPmIyNKry51Pg2UFd
> nzrgjrI5gHczEFjd4kC5l/Midi3XtY5EsfjMuDdN9+Ccs/P+JTSBv+bRSLMdNVrv
> 4F/Rvlz0d8eek2MgO5OnvSaXFr+1s+/+tb5bTAwA1MVUOGt3GjgFWk8rLim/9ESF
> OMfTljs1GJp0sVsZ4wwNN+gqEg7vdXQsslqdkbbHNWbbbDa54OKG0y9T/nc1UbCM
> wpul0IhJBBgRAgAJBQJGuD3oAhsMAAoJENJ5Bj3tTq6WUzcAoJIVpSZAYflDWhlh
> mamFWG+xnRwtAKCLvw9B8LpfAYcvSTWhWvFldz0AAw==
> =PDDZ
> -----END PGP PUBLIC KEY BLOCK-----
> 
> 

Andrew Butkus
butkus.co.uk

My public key for contacting me securely:

-----BEGIN PGP PUBLIC KEY BLOCK-----
Version: GnuPG v1.4.6 (GNU/Linux)

mQGiBEa4PeMRBADajg5zW8sM2AkcVfXf/xwKM0mc39MpSLCUwGib5riy4RVpzy4g
tSvq5s1xpgyaovKiSbRG36PiArrymnHq9O1qCp6+qWqdhaqxuk37LoABQbQ9sXxu
0jPYASRN1kTR2tJLklCpmYGvkXPsXe9tx2hBUur6aRbhbkdJyaNCf8JwhwCgkzOC
ayExrr0DFOiUzXY3XDorFe8EAJgEgIETrS28RHnKh5fOQNp6MYQjmoo7JINXwZTd
M7WehjbLnytlkBieRAT0Ex8FOesxBS1KkS32xFcN91noiXpOYo/7UcUB1kBXLrdW
3FhtGRnBLVMfQljFePhR5BclY/LSKIjwtVBimVd4qQMrYYo3AtGtSz8/VDSSgRlm
qnADA/44AGz2/qkSormq2aAh7WFGszoAtywc+RTNwskUPboDSfn3cBdmwTcqG2dJ
K2oiL7HaXuj+Nga8omk4wQdUnig02btc+lLlxkHCW00mfdlblQswpbwEwlZa4Mtl
hlAreQP1oNTvRcLWPzrC7CqBkOUPxvilipP3c4HWXYrSXsqPGLQ7QW5kcmV3IEJ1
dGt1cyAoQW5kcmV3J3MgR1BHIGtleSBwYWlyKSA8YW5kcmV3QGJ1dGt1cy5jby51
az6IYAQTEQIAIAUCRrg94wIbAwYLCQgHAwIEFQIIAwQWAgMBAh4BAheAAAoJENJ5
Bj3tTq6WEu0AnAsYEPElmoDEzIdbTZJgIWTMeSqdAJ9GrLmAY0fwCyt2l6DC9+IQ
fGen6rkCDQRGuD3oEAgA714L70CoVgdTphWoza4AW7n4WA7NhgWOsTf/uyV8XV5N
6FIvrAWSbueIGnpSYeyEiaQeEsCx5VltWZ5BxxSpWl1vmPwWd5OplUFx2dOpXP+N
BEghG+StFRVPl350IB3WAvWJHOcbxpWwefnc8kG5GUWZSCY0rrOq4/AZaEdmMwrh
hMmXUUEJnkO4nLjQgkNIQO9dVzVX+Cm8AuhYqyz2htp7nW6kIq5AFEmk7WZ4PaKZ
6fs0KwSF0n978hf8/IprDSNgUOirXtfTxUvB21/lBVY07FrgN5mncKEt1SN3mIny
++GYlYFWkPVrT3YAymAxXHFl7kjzki3SE0ugAOrgWwADBgf9E1gK3d9EGmmwAevG
ZR77toj1kUnkta0ZnnZ0bd+cs9L/VWUBrA4Hk4fsXiLw94yAZyUyMA6topEi7vcD
JV/hTxtgb+xfnXygdzXtaG3sJlKYOv72aVnvfiELn5lKwOpGPmIyNKry51Pg2UFd
nzrgjrI5gHczEFjd4kC5l/Midi3XtY5EsfjMuDdN9+Ccs/P+JTSBv+bRSLMdNVrv
4F/Rvlz0d8eek2MgO5OnvSaXFr+1s+/+tb5bTAwA1MVUOGt3GjgFWk8rLim/9ESF
OMfTljs1GJp0sVsZ4wwNN+gqEg7vdXQsslqdkbbHNWbbbDa54OKG0y9T/nc1UbCM
wpul0IhJBBgRAgAJBQJGuD3oAhsMAAoJENJ5Bj3tTq6WUzcAoJIVpSZAYflDWhlh
mamFWG+xnRwtAKCLvw9B8LpfAYcvSTWhWvFldz0AAw==
=PDDZ
-----END PGP PUBLIC KEY BLOCK-----
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/octet-stream
Size: 6667 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20070812/4357acc4/attachment.obj>