[FFmpeg-devel] [PATCH] h264: don't check decode_cabac_residual return

Alexander Strange astrange
Sat Aug 11 23:44:41 CEST 2007


decode_cabac_residual returns 'int', and some callers check against  
it, but it never actually returns anything but 0.
This patch changes it to return void and removes the checks, since  
there weren't any TODOs there about it.

Before:
BENCHMARKs: VC:  25.319s VO:   1.817s A:   0.000s Sys:   0.194s =    
27.330s
BENCHMARKs: VC:  25.320s VO:   1.831s A:   0.000s Sys:   0.193s =    
27.345s
BENCHMARKs: VC:  25.326s VO:   1.819s A:   0.000s Sys:   0.195s =    
27.341s
BENCHMARKs: VC:  25.319s VO:   1.815s A:   0.000s Sys:   0.196s =    
27.330s
avg: 25.321

After:
BENCHMARKs: VC:  25.211s VO:   1.825s A:   0.000s Sys:   0.199s =    
27.235s
BENCHMARKs: VC:  25.207s VO:   1.828s A:   0.000s Sys:   0.195s =    
27.229s
BENCHMARKs: VC:  25.212s VO:   1.821s A:   0.000s Sys:   0.194s =    
27.228s
BENCHMARKs: VC:  25.209s VO:   1.822s A:   0.000s Sys:   0.195s =    
27.226s
avg: 25.209

A lot of other small beneficial changes generate worse code in gcc :(
Good thing the current "rewrite the register allocator" project might  
actually finish by 4.4...

?



More information about the ffmpeg-devel mailing list