[FFmpeg-devel] [PATCH] Possible bugfix for matroskadec.c
Fri Aug 10 19:27:42 CEST 2007
Aurelien Jacobs <aurel at gnuage.org> writes:
> On Fri, 10 Aug 2007 18:16:28 +0300
> Uoti Urpala <uoti.urpala at pp1.inet.fi> wrote:
>> On Fri, 2007-08-10 at 17:10 +0200, Aurelien Jacobs wrote:
>> > On Fri, 10 Aug 2007 10:57:05 +0200
>> > Carl Eugen Hoyos <cehoyos at ag.or.at> wrote:
>> > > matroskadec.c(2385): warning #186: pointless comparison of unsigned
>> > > integer with zero
>> > > if (cluster_time != (uint64_t)-1 && cluster_time + block_time >= 0)
>> > cluster_time + block_time is not unsigned ! I would consider this is
>> > a bug in icc...
>> It is unsigned. uint64_t cluster_time
> I don't know why, but I thought that unsigned+signed would result in
> a signed type...
Only if the wider of the two types being added is signed and wide
enough to hold the full range of the unsigned type.
mans at mansr.com
More information about the ffmpeg-devel