[FFmpeg-devel] [PATCH/RFC] Ryan Martell's native mms code

[Michael Niedermayer]

Hi

On Thu, Aug 09, 2007 at 03:28:26PM +0200, Bj?rn Axelsson wrote:
> On Thu, 2007-08-09 at 14:35 +0200, Reimar D?ffinger wrote:
> > Hello,
> > On Thu, Aug 09, 2007 at 02:24:08PM +0200, Bj?rn Axelsson wrote:
> > > I have merged Ryan's native_mms work mentioned in an earlier mail with
> > > the SVN trunk, to produce an easily reviewed patch. I have tried not to
> > > change anything from Ryan's code except what was needed to make it
> > > compile.
> > > 
> > > native_mms.c is mostly and will still require substantial work until it
> > > is acceptable. It should probably also be split up into three files: one
> > > for common functions, one for tcp/udp and one for http. 
> > 
> > Actually I don't see why it needs to be a demuxer at all instead of only
> > a protocol. At least in MPlayer splitting it this way works (though
> > stream selection admittedly is ugly and possibly not suitable in this
> > way for ffmpeg).
> 
> I don't have enough knowledge about the ffmpeg internals to say whether
> it is possible or not to implement it as a protocol instead. However, it
> seems that rtsp is implemented as a demuxer and I would guess that
> native_mms.c is based in part on rtsp.c.

noone understands rtsp.c so this is not a good start ...


> If mms was implemented as a protocol, the asf demuxer would have to take
> over the application interface for much of the functionality such as
> playing, pausing and seeking with different cases for file and mms
> access. If that is acceptable I'll give it a try and see if I run into
> any problems.

hmm, is there more needed than

asf_seek(stuff){
    if(mms){
        int ret= context->protocol.seek(stuff);
        flush_everything();
        return ret;
    }
}

?

if so please elaborate, i know nothing about mms, but iam the poor guy who
will have to review the patch in the end i guess ...


[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

I have often repented speaking, but never of holding my tongue.
-- Xenocrates
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20070809/b2060bd1/attachment.pgp>