[FFmpeg-devel] [PATCH] Move poll() out of libavformat
Ramiro Ribeiro Polla
ramiro
Wed Aug 8 13:57:53 CEST 2007
wrote:
>> Hi,
>>
>>
>>> Currently, for systems that lack poll(), an emulation is
>>> implemented in
>>> libavformat/os_support.c. I don't think it's a good idea to make
>>> the
>>> library export poll(), and since only ffserver.c uses it, I suggest
>>> to
>>> move it to ffserver.c
>>>
>> Generally I don't like this, what if we'll use poll() in an other
>> place?
>> Move it again?
>>
>>
>
> We can also use a private name for it and #define poll ff_os_poll in
> os_support.h
>
>
Well, defining poll to ff_os_poll in a public header seems just as bad
as exporting poll() in a lib. What about making ffserver use ff_os_poll
instead of poll?
Ramiro Polla
More information about the ffmpeg-devel
mailing list