[FFmpeg-devel] [PATCH] activate ac3 decoder

[Diego Biurrun]

On Sat, Aug 04, 2007 at 09:36:05PM -0400, Justin Ruggles wrote:
>
> The AC-3 decoder is at a point where it can be activated.  Really it has 
> been working for a while, but I wanted to get downmixing correct before 
> activating it.  This patch works for me, but I'm not absolutely sure that 
> it's the correct way to do it.
>
> I'm definitely not done with the changes to the decoder...I just think it 
> has enough working features now to be fully included in FFmpeg.
>
> For now it's still licensed as GPL.  I'm about 95% confident that the parts 
> derived from liba52 are now gone, but I'm not 100% sure.  Once the E-AC3 
> decoder is added and if Michel Lespinasse gives his blessing, then it can 
> be changed to LGPL at that time.

You could also just ask Michel if he thinks they are gone.  If he gives
his blessing, all would be well.

> --- configure	(revision 9911)
> +++ configure	(working copy)
> @@ -1594,6 +1595,9 @@
>  
> +# disable the native AC-3 decoder if liba52 is enabled
> +enabled liba52 && disable ac3_decoder

Possibly we should remove liba52 support, same as we did for
libdca/libdts.

The patch is fine, commit anytime.

Diego