[FFmpeg-devel] [PATCH/v2] Realmedia RTSP (RDT) support

Michael Niedermayer michaelni
Sun Aug 5 15:14:38 CEST 2007


Hi

On Sat, Jul 21, 2007 at 04:04:21PM -0400, Ronald S. Bultje wrote:
> Hi,
>
> On 7/19/07, Michael Niedermayer <michaelni at gmx.at> wrote:
>>
>> On Thu, Jul 19, 2007 at 12:39:02PM -0400, Ronald S. Bultje wrote:
>> > On 7/19/07, Michael Niedermayer <michaelni at gmx.at> wrote:
>> > > On Mon, Jul 16, 2007 at 12:33:04AM -0400, Ronald S. Bultje wrote:
>> > > > Index: ffmpeg/libavformat/rtsp.c
>> > > > ===================================================================
>> > > > --- ffmpeg.orig/libavformat/rtsp.c    2007-07-14 14:24:
>> 43.000000000-0400
>> > > > +++ ffmpeg/libavformat/rtsp.c 2007-07-16 00:24:38.000000000 -0400
>> > > > @@ -609,11 +609,12 @@
>> > > >              p++;
>> > > >          get_word_sep(profile, sizeof(profile), "/;,", &p);
>> > > >          lower_transport[0] = '\0';
>> > > > -        if (*p == '/') {
>> > > > +        if (*p == '/') { /* rtp/avp/<protocol> */
>> > > >              p++;
>> > > >              get_word_sep(lower_transport, sizeof(lower_transport),
>> > > >                           ";,", &p);
>> > > > -        }
>> > > > +        } else /* x-pn-tng/<protocol> */
>> > > > +            av_strlcat(lower_transport, profile,
>> > > sizeof(lower_transport));
>> > > >          if (!strcasecmp(lower_transport, "TCP"))
>> > > >              th->protocol = RTSP_PROTOCOL_RTP_TCP;
>> > > >          else
>> > >
>> > > this will totally break normal rtp but iam not rt*p maintainer
>> >
>> >
>> > I'm probably missing something - why would it break? The first half of
>> the
>> > function should take care of normal RTP (which always has
>> > rtp/avp/<protocol>, at least as far as I've seen). Unless someone uses
>> tcp
>> > as profile, outcome is always the same, no? I can handle this
>> differently to
>> > allow that (tcp as profile...) also, if you'd prefer.
>>
>> "rtp/avp" would end in the else and set lower_transport to avp which is
>> nonsense
>>
>> you should explicitly check if its "rtp" or "x-pn-tng" and not assume that
>> a single / means "x-pn-tng"
>
>
> $attached.

rtsp maintainer, ping!

the patch looks ok to me excedpt that it should do the reindent in a seperate
patch
and the addition of the comment in a third patch ideally ;)


[...]

-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

When the tyrant has disposed of foreign enemies by conquest or treaty, and
there is nothing more to fear from them, then he is always stirring up
some war or other, in order that the people may require a leader. -- Plato
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20070805/ff0aecb2/attachment.pgp>



More information about the ffmpeg-devel mailing list