[FFmpeg-devel] [PATCH] handle INT32INFO in WavPack decoder

[David Bryant]

Hi.

Kostya wrote:
> On Sat, Aug 04, 2007 at 10:06:53PM -0700, David Bryant wrote:
>> Hi.
>>
>> Michael Niedermayer wrote:
>>> Hi
>>>
>>> On Sat, Aug 04, 2007 at 03:39:13PM -0700, David Bryant wrote:
>>>> Hi.
>>>>
>>>> This patch adds the handling of the INT32INFO block to the WavPack 
>>>> decoder. This block is used to properly decode integer samples over 24 
>>>> bits, 
>>> the dst array into which the values get stored is 16bit, how is this 
>>> supposed
>>> to work?
>> The WavPack decoder in FFmpeg currently handles only 16-bit audio. I 
>> suspect that the original author assumed that the INT32INFO block was 
>> only used for large integers and that's why he did not implement it.
>>
>> However, since that block is also used for 16-bit audio when the LSB 
>> redundancies are detected, I thought it would be good to add it. Without 
>> it, some vanilla 16-bit stereo files will fail to decode.
> 
> Well, the name is a bit misleading. 
>  

Agreed.

[...]

> 
> Applied, thanks for the patch 
>  

Thanks for the implementation!  :)

BTW, as time permits I would like to submit more patches to allow more 
of the WavPack test suite files to play/convert in FFmpeg. Was there a 
philosophical or implementational reason that the lossy mode was not 
incorporated, or was it just an issue of time/effort?

Regards,

David