[FFmpeg-devel] [PATCH] make sure blending the subtitle does not write outside buffer

Reimar Döffinger Reimar.Doeffinger
Sun Aug 5 12:36:34 CEST 2007


Hello,
On Sun, Aug 05, 2007 at 12:12:26PM +0200, Michael Niedermayer wrote:
> On Sun, Aug 05, 2007 at 11:00:04AM +0200, Reimar D?ffinger wrote:
> > attached patch fixes the subtitle rectangles so they do not lie outside
> > the video, which can cause crashes.
> 
> hmm, this seems like a hack to me
> shouldnt blend_subrect "skip" the parts of a rectange which are outside
> of the image?

well, unfortunately blend_subrect does not currently know the size of
the image. But more importantly, what is the point of showing half-cut
subtitles? At least I don't have any use for subtitles where I can read
e.g. only the upper half.

Greetings,
Reimar D?ffinger




More information about the ffmpeg-devel mailing list