[FFmpeg-devel] MP2 file tagged with MP3

[Michael Niedermayer]

Hi

On Sun, Aug 05, 2007 at 02:50:29AM +0200, Baptiste Coudurier wrote:
> Hi
> 
> Michael Niedermayer wrote:
> > Hi
> > 
> > On Sat, Aug 04, 2007 at 12:37:29AM +0200, Baptiste Coudurier wrote:
> >> Hi
> >>
> >> Michael Niedermayer wrote:
> >>> Hi
> >>>
> >>> On Fri, Aug 03, 2007 at 07:07:15PM +0200, herve.flores wrote:
> >>>> Hi,
> >>>> since r9102, ffmpeg write headers of mp2 files with mp3 tags
> >>>> related threads
> >>>>
> >>>> [...]
> >>>>
> >>> no patch -> wrong mailinglist 
> >>> and before you waste more time find a solid proof that this is not a valid
> >>> mp2 file
> >>> solid are
> >>> * refering to the mpeg audio spec
> >>> * showing that the reference mpeg audio decoder fails
> >>> * some hardware mp2/vcd/... decoder failing
> >>> not solid are
> >>> * mplex
> >>> * file
> >>>
> >> Well, having id3 tag when writing mp2 files, when stream copy for
> >> example, might be annoying, if user wants id3 tag he can use .mp3 and
> >> -acodec mp2.
> > 
> > hmm indeed, i agree
> > feel free to apply the patch to svn (dont forget the regression tests though)
> > 
> 
> Applied. Regression tests did not need to be updated here, it seems
> weird, my tree might be damaged.

no, its ok, mp3_write_header() does nothing if it doesnt have anything to
write in the id3 thing ...

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

The worst form of inequality is to try to make unequal things equal.
-- Aristotle
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20070805/31095a6b/attachment.pgp>