[FFmpeg-devel] PATCH: configure, with fixedpoint CONFIG

Måns Rullgård mans
Thu Aug 2 09:35:09 CEST 2007


Diego Biurrun <diego at biurrun.de> writes:

> On Thu, Aug 02, 2007 at 08:30:57AM +0200, Diego Biurrun wrote:
>> On Thu, Aug 02, 2007 at 12:40:12AM +0100, M?ns Rullg?rd wrote:
>> > "Marc Hoffman" <mmhoffm at gmail.com> writes:
>> > 
>> > > Adding just the configure aspect of fixedpoint, control.  Breaking
>> > > things up into small pieces.
>> > >
>> > > --- configure	(revision 9848)
>> > > +++ configure	(working copy)
>> > > @@ -581,6 +582,7 @@
>> > >      bktr
>> > >      dc1394
>> > >      dv1394
>> > > +    fixedpoint
>> > >      ffmpeg
>> > >      ffplay
>> > >      ffserver
>> > 
>> > OK
>> 
>> Not OK, this is not alphabetical order.

Dang, didn't notice that...

>> Also, while splitting patches into small pieces is generally desirable,
>> I do not think it makes sense to apply this without some code that
>> actually uses it.
>
> I see this was already committed.  What is the point of this patch
> anyway?

When I said OK, I naturally meant that the change is OK as such,
provided it makes sense.  Alone, without any code depending on the
option, it is senseless and should not have been committed.

-- 
M?ns Rullg?rd
mans at mansr.com




More information about the ffmpeg-devel mailing list