[Ffmpeg-devel] [PATCH] avoid calling a NULL function in swscale.c

[Benoit Fouet]

Hi,

Michael Niedermayer wrote:
> Hi
>
> On Thu, Apr 26, 2007 at 02:15:27PM +0200, Benoit Fouet wrote:
>   
>> Hi,
>>
>> Michael Niedermayer wrote:
>>     
>>> Hi
>>>
>>> On Thu, Apr 26, 2007 at 11:29:22AM +0200, Benoit Fouet wrote:
>>>   
>>>       
>>>> Hi,
>>>>
>>>> patch 1: add a test on conversion function prior to try to apply it
>>>>     
>>>>         
>>> and what is this good for? producing wrong output which is hard to debug
>>> instead of segfault which is easy to find the cause of?
>>>
>>>
>>>   
>>>       
>> there's already a message:
>> av_log(c, AV_LOG_ERROR, "swScaler: internal error %s -> %s converter\n",
>>                  sws_format_name(srcFormat), sws_format_name(dstFormat));
>>
>> isn't it enough ?
>>     
>
> it is, patch ok
>
> [...]
>   
>   
ok, i cannot apply it by myself
i attach updated patches (and indentation is done with tabs, to be
compliant with what exists in swscale.c)

Ben

-- 
Purple Labs S.A.
www.purplelabs.com
-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: swscale.c.1.diff
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20070427/3489dcdb/attachment.txt>
-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: swscale.c.2.diff
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20070427/3489dcdb/attachment.asc>